Re: [PATCH 04/12] fs/ceph/super.h: convert ceph_inode_xattr fields to `bool`

From: Viacheslav Dubeyko

Date: Tue Jun 30 2026 - 12:14:16 EST


On Fri, 2026-06-12 at 18:51 +0200, Max Kellermann wrote:
> This reduces the size of `struct ceph_inode_xattr` by 8 bytes.
>
> Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
> ---
>  fs/ceph/super.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index f0f03aeb5b19..18960a9e735a 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -318,10 +318,10 @@ struct ceph_inode_xattr {
>   int name_len;
>   const char *val;
>   int val_len;
> - int dirty;
> + bool dirty;
>  
> - int should_free_name;
> - int should_free_val;
> + bool should_free_name;
> + bool should_free_val;
>  };
>  
>  /*

To use the bool instead of int data type looks good.

Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>

Thanks,
Slava.