Re: [PATCH v3] ASoC: dt-bindings: Convert cirrus,cs35l36 to DT schema

[Rob Herring (Arm)]

On Wed, 24 Jun 2026 23:10:02 +0200, David Heidelberg wrote:
> Convert CS35L36 Speaker Amplifier to yaml.
> 
> Changes:
>  - maintainers email to the generic Cirrus email
>  - Both the codec and downstream worked just fine without
>    VP-supply provided. Align with datasheet for similar models.
>  - add dai-common.yaml to cover for '#sound-dai-cells',
>    'sound-name-prefix'
>  - updated not yet implemented:
>      cirrus,weak-fet-delay -> cirrus,classh-wk-fet-delay-ms
>        (in both definition and example)
>      cirrus,weak-fet-thld -> cirrus,weak-fet-thld-millivolt
>        (only in the example)
>  - added two required properties:
>      cirrus,boost-ctl-millivolt
>      cirrus,boost-peak-milliamp
> 
> Assisted-by: OpenAI:gpt-4
> Reviewed-by: David Rhodes <David.Rhodes@xxxxxxxxxx>
> Co-developed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> Signed-off-by: David Heidelberg <david@xxxxxxx>
> ---
> Relevant for Pixel 3 / 3XL / 4.
> ---
> Changes in v3:
> - Corrected properties which has been unimplemented and also
>   conflicting between definition and the sample.
> - Removed units from description where units are part of the property
>   name.
> - Added sound into the $id path. (Mark)
> - Readded James and removed Bjorn. (Rob)
> - Made path to dai-common shorter.
> - Added two required properties
>   cirrus,boost-ctl-millivolt and cirrus,boost-peak-milliamp.
> - Use $defs for the cirrus,vpbr-config to prevent matching it against
>   vendor defined properties. The driver is already mainlined with
>   cirrus, vendor part, so we have to keep it compatible.
> - Link to v2: https://lore.kernel.org/r/20260624-dt-cirrus-cs35l36-v2-1-74eccdbd8fe4@xxxxxxx
> 
> Changes in v2:
> - Rename the commit. (Mark)
> - Link to v1: https://lore.kernel.org/r/20260618-dt-cirrus-cs35l36-v1-1-1a43515666ad@xxxxxxx
> ---
>  .../devicetree/bindings/sound/cirrus,cs35l36.yaml  | 240 +++++++++++++++++++++
>  .../devicetree/bindings/sound/cs35l36.txt          | 168 ---------------
>  2 files changed, 240 insertions(+), 168 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>