Re: [PATCH 3/3] hwmon: (pmbus/fd5121): Add support FD5121, FD5123 and FD5125

[Uwe Kleine-König]

Hello,

On Mon, Jun 22, 2026 at 10:55:39PM -0700, Selvamani Rajagopal via B4 Relay wrote:
> +static const struct i2c_device_id fd5121_id[] = {
> +	{ "fd5121", chip_fd5121 },
> +	{ "fd5123", chip_fd5123 },
> +	{ "fd5125", chip_fd5125 },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(i2c, fd5121_id);

Please make this:

	static const struct i2c_device_id fd5121_id[] = {
		{ .name = "fd5121", .driver_data = chip_fd5121 },
		{ .name = "fd5123", .driver_data = chip_fd5123 },
		{ .name = "fd5125", .driver_data = chip_fd5125 },
		{ }
	};
	MODULE_DEVICE_TABLE(i2c, fd5121_id);

See e.g.
https://lore.kernel.org/lkml/20260515103150.164887-2-u.kleine-koenig@xxxxxxxxxxxx/
for the rationale.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature