Re: [PATCH v2 1/3] perf/dwc_pcie: Add support for Picoheart vendor devices

[Yicong Yang]

On 6/30/26 7:31 PM, Niklas Cassel wrote:
> On Mon, Jun 29, 2026 at 05:27:15PM +0800, Yicong Yang wrote:
>> Add PCI_VENDOR_ID_PICOHEART in pci_ids.h. Update the DWC PCIe
>> vendor table with Picoheart PCIe vendorid to enable the PCIe
>> PMU support.
>>
>> Signed-off-by: Yicong Yang <yang.yicong@xxxxxxxxxxxxx>
>> ---
>>  include/linux/pci_ids.h  | 2 ++
>>  include/linux/pcie-dwc.h | 2 ++
>>  2 files changed, 4 insertions(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 1c9d40e09107..2c17239aacea 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2640,6 +2640,8 @@
>>  #define PCI_VENDOR_ID_SUNIX		0x1fd4
>>  #define PCI_DEVICE_ID_SUNIX_1999	0x1999
>>  
>> +#define PCI_VENDOR_ID_PICOHEART		0x20fa
>> +
>>  #define PCI_VENDOR_ID_HINT             0x3388
>>  #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>>  
>> diff --git a/include/linux/pcie-dwc.h b/include/linux/pcie-dwc.h
>> index 8ff778e7aec0..b0ccb2ad74db 100644
>> --- a/include/linux/pcie-dwc.h
>> +++ b/include/linux/pcie-dwc.h
>> @@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
>>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>>  	{ .vendor_id = PCI_VENDOR_ID_SAMSUNG,
>>  	  .vsec_id = 0x02, .vsec_rev = 0x4 },
>> +	{ .vendor_id = PCI_VENDOR_ID_PICOHEART,
>> +	  .vsec_id = 0x02, .vsec_rev = 0x4 },
> 
> Could you please point to the in-tree device driver for this
> DWC based "picoheart" PCIe controller?
> 
> $ git grep -i picoheart drivers/pci/controller/dwc/
> <nothing>
> 
> It feels wrong to add PMU support for a PCIe controller,
> if that PCIe controller does not have support in mainline.
> 

we're using ACPI thus go through the common ACPI PCI code
for PCIe controller itself. it's same to the already listed
alibaba and ampere here (suppose they're also ACPI based system).

thanks.