Re: [PATCH v2 1/3] perf/dwc_pcie: Add support for Picoheart vendor devices

[Yicong Yang]

On 6/30/26 11:35 AM, Shuai Xue wrote:
> 
> 
> On 6/29/26 5:27 PM, Yicong Yang wrote:
>> Add PCI_VENDOR_ID_PICOHEART in pci_ids.h. Update the DWC PCIe
>> vendor table with Picoheart PCIe vendorid to enable the PCIe
>> PMU support.
>>
>> Signed-off-by: Yicong Yang <yang.yicong@xxxxxxxxxxxxx>
>> ---
>>   include/linux/pci_ids.h  | 2 ++
>>   include/linux/pcie-dwc.h | 2 ++
>>   2 files changed, 4 insertions(+)
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 1c9d40e09107..2c17239aacea 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -2640,6 +2640,8 @@
>>   #define PCI_VENDOR_ID_SUNIX        0x1fd4
>>   #define PCI_DEVICE_ID_SUNIX_1999    0x1999
>>   +#define PCI_VENDOR_ID_PICOHEART        0x20fa
>> +
>>   #define PCI_VENDOR_ID_HINT             0x3388
>>   #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>>   diff --git a/include/linux/pcie-dwc.h b/include/linux/pcie-dwc.h
>> index 8ff778e7aec0..b0ccb2ad74db 100644
>> --- a/include/linux/pcie-dwc.h
>> +++ b/include/linux/pcie-dwc.h
>> @@ -32,6 +32,8 @@ static const struct dwc_pcie_vsec_id dwc_pcie_rasdes_vsec_ids[] = {
>>         .vsec_id = 0x02, .vsec_rev = 0x4 },
>>       { .vendor_id = PCI_VENDOR_ID_SAMSUNG,
>>         .vsec_id = 0x02, .vsec_rev = 0x4 },
>> +    { .vendor_id = PCI_VENDOR_ID_PICOHEART,
>> +      .vsec_id = 0x02, .vsec_rev = 0x4 },
>>       {}
>>   };
>>   
> 
> Hi Yicong,
> 
> The pci_ids.h part looks good to me. Minor, the new entry in
> pcie-dwc.h breaks the alphabetical ordering of the table
> 
> Could you please move the PICOHEART entry between AMPERE and QCOM to
> keep the list sorted alphabetically?

sure, will do. sorry for my careless ignore.

> 
> With that fixed,
> 
> Reviewed-by: Shuai Xue <xueshuai@xxxxxxxxxxxxxxxxx>
> 

thanks.