Re: [PATCH v2 5/5] watchdog: dev: convert to kernel-doc comments

From: Manuel Ebner

Date: Tue Jun 30 2026 - 14:55:29 EST


On Fri, 2026-05-29 at 14:20 -0700, Randy Dunlap wrote:
> [...]
>
> @@ -659,7 +659,7 @@ __ATTRIBUTE_GROUPS(wdt);
>  #define wdt_groups NULL
>  #endif
>  
> -/*
> +/**
>   * watchdog_ioctl_op - call the watchdog drivers ioctl op if defined

Maybe this is better:
* watchdog_ioctl_op - call the watchdog drivers ioctl operation if defined
 
> [...] 
> @@ -732,7 +732,7 @@ static ssize_t watchdog_write(struct fil
>   return len;
>  }
>  
> -/*
> +/**
>   * watchdog_ioctl - handle the different ioctl's for the watchdog device

I think it's plural:
* watchdog_ioctl - handle the different ioctls for the watchdog device

>   * @file: File handle to the device
>   * @cmd: Watchdog command

Thanks
Manuel