Re: [PATCH] ata: sata_dwc_460ex: use platform_get_irq()

From: Rosen Penev

Date: Tue Jun 30 2026 - 16:11:35 EST


On Tue, Jun 30, 2026 at 4:16 AM Niklas Cassel <cassel@xxxxxxxxxx> wrote:
>
> On Tue, Jun 30, 2026 at 07:06:55PM +0900, Damien Le Moal wrote:
> > On 6/30/26 18:55, Niklas Cassel wrote:
> > > Sure, we could create a dummy / stub for that function, but to be honest,
> > > I think my earlier suggestion of just using dev->of_node directly within
> > > the ifdef, and drop the local np variable would be the smallest change.
> >
> > Yes. But I am not against replacing that ifdef with IS_ENABLED().
> > That's prettier :)
>
> That is possible if we create a dummy / stub for sata_dwc_dma_init_old()
> (since that function is currently defined within #ifdef).
Yeah for that reason I'll keep it as it.
>
>
> Kind regards,
> Niklas