Re: [PATCH] RAS/AMD/ATL, EDAC/amd64: Only load ATL when needed

[Borislav Petkov]

On Tue, Jun 30, 2026 at 12:26:05AM -0500, Mario Limonciello wrote:
> From: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> 
> The AMD Address Translation Library (ATL) will attempt to load on all
> AMD Zen/SMCA systems.
> 
> However, only systems with DRAM ECC enabled will use the library. Other
> systems will fail to load the library and produce an unnecessary message
> to the user.
> 
> Remove the ATL module dependency table to prevent autoloading. Request
> ATL to load from EDAC once all system checks are complete.
> 
> Fixes: 3f3174996be6 ("RAS: Introduce AMD Address Translation Library")
> Reported-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> Closes: https://lore.kernel.org/20260305154528.1171999-1-mario.limonciello@xxxxxxx
> Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
> Tested-by: Deskhmukh Shrirang <Shrirang.Deskhmukh@xxxxxxx>
> Link: https://lore.kernel.org/all/20260307144910.GA113343@xxxxxxxxxxxxxxxxx/
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> ---
>  drivers/edac/amd64_edac.c  | 2 ++
>  drivers/ras/amd/atl/core.c | 1 -
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
> index c6aa69dbd9fb1..01b1e569d98e9 100644
> --- a/drivers/edac/amd64_edac.c
> +++ b/drivers/edac/amd64_edac.c
> @@ -4173,6 +4173,8 @@ static int __init amd64_edac_init(void)
>  		goto err_pci;
>  	}
>  
> +	request_module("amd_atl");

	request_module_nowait()

I still am not escatic about it but I guess that's fine, considering that we
really only want to load it on ECC DIMMs machines with actual DRAM error
producers successfully loaded.

Oh well.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette