Re: [PATCH v1 1/2] Documentation: dt: reset: add mediatek,syscon-reset binding
From: Peter Wang (王信友)
Date: Wed Jul 01 2026 - 02:37:44 EST
On Fri, 2026-06-26 at 16:53 +0100, Conor Dooley wrote:
>
> It isn't going to exist, since we will chuck a fit at the underscore!
>
Hi Conor,
Thanks for the review.
I apologize for the mistake in using this bad examples.
I will remove it in the next version.
> >
> > > + reg = <0x16840000 0x1000>;
> > > + #address-cells = <1>;
> > > + #size-cells = <1>;
> > > +
> > > + ufs0cfgao_rst: reset-controller {
> > > + compatible = "mediatek,syscon-reset";
> >
> > It looks to me like this is just two registers inside ufs0cfg_ao,
> > not a
> > separate device. Why don't you just add #reset-cells to the parent
> > node?
>
> I concur, seems like it should be in the parent.
> pw-bot: changes-requested
>
>
This is for flexibility in MediaTek SoCs, as described in the
previous email.
Thanks
Peter