Re: [PATCH v3 10/16] x86/virt: Use higher-level allocator API

[Vlastimil Babka (SUSE)]

On 6/29/26 15:11, Brendan Jackman wrote:
> The difference between __alloc_pages_node() and alloc_pages_node() is
> that the latter allows you to pass NUMA_NO_NODE.
> 
> The former is going away and the latter works fine here so switch over.
> 
> No functional change intended.
> 
> Cc: Thomas Gleixner <tglx@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Assisted-by: Gemini:unknown-version
> Reviewed-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>

Reviewed-by: Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx>

> ---
>  arch/x86/virt/hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/virt/hw.c b/arch/x86/virt/hw.c
> index 7e9091c640be0..a236447ac7a26 100644
> --- a/arch/x86/virt/hw.c
> +++ b/arch/x86/virt/hw.c
> @@ -196,7 +196,7 @@ static __init int __x86_vmx_init(void)
>  		struct page *page;
>  		struct vmcs *vmcs;
>  
> -		page = __alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0);
> +		page = alloc_pages_node(node, GFP_KERNEL | __GFP_ZERO, 0);
>  		if (WARN_ON_ONCE(!page)) {
>  			x86_vmx_exit();
>  			return -ENOMEM;
>