Re: [PATCH v3 11/16] sgi-xp: Use higher-level allocator API

[Brendan Jackman]

On Wed Jul 1, 2026 at 7:52 AM UTC, Vlastimil Babka (SUSE) wrote:
> On 6/29/26 15:12, Brendan Jackman wrote:
>> The difference between __alloc_pages_node() and alloc_pages_node() is
>> that the latter allows you to pass NUMA_NO_NODE.
>> 
>> The former is going away and the latter works fine here so switch over.
>> 
>> No functional change intended.
>> 
>> Cc: Robin Holt <robinmholt@xxxxxxxxx>
>> Cc: Steve Wahl <steve.wahl@xxxxxxx>
>> Cc: Arnd Bergmann <arnd@xxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Assisted-by: Gemini:unknown-model
>> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> Reviewed-by: Suren Baghdasaryan <surenb@xxxxxxxxxx>
>> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
>
> Reviewed-by: Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx>
>
> Nit:
>
>> ---
>>  drivers/misc/sgi-xp/xpc_uv.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xpc_uv.c
>> index 772c787268932..aacff70204241 100644
>> --- a/drivers/misc/sgi-xp/xpc_uv.c
>> +++ b/drivers/misc/sgi-xp/xpc_uv.c
>> @@ -170,7 +170,7 @@ xpc_create_gru_mq_uv(unsigned int mq_size, int cpu, char *irq_name,
>>  	mq->mmr_blade = uv_cpu_to_blade_id(cpu);
>>  
>>  	nid = cpu_to_node(cpu);
>> -	page = __alloc_pages_node(nid,
>> +	page = alloc_pages_node(nid,
>>  				      GFP_KERNEL | __GFP_ZERO | __GFP_THISNODE,
>>  				      pg_order);
>
> gfp flags can now fit on the line above?

Ack.