Re: [PATCH v3 12/16] ALSA: hda/core: Add include defining struct hda_device_id

[Takashi Iwai]

On Sun, 28 Jun 2026 23:58:47 +0200,
Uwe Kleine-König (The Capable Hub) wrote:
> 
> Traditionally all *_device_id were defined in a single header
> <linux/mod_devicetable.h>. This was split now with the objective that
> only the relevant bits are included. So including <linux/pci.h> won't be
> enough to get a definition of (the unrelated to pci) struct
> hda_device_id.
> 
> Add an explicit include for the header defining struct hda_device_id to
> keep working when <linux/pci.h> stops providing this defintion.
> 
> Acked-by: Danilo Krummrich <dakr@xxxxxxxxxx>
> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@xxxxxxxxxxxx>

I sent wrongly to v2, so again:

Reviewed-by: Takashi Iwai <tiwai@xxxxxxx>


thanks,

Takashi

> ---
>  include/sound/hdaudio.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index f11bfc6b9f42..aa994d6e6d35 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -11,6 +11,7 @@
>  #include <linux/io.h>
>  #include <linux/io-64-nonatomic-lo-hi.h>
>  #include <linux/iopoll.h>
> +#include <linux/device-id/hda.h>
>  #include <linux/pci.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/timecounter.h>
> -- 
> 2.47.3
>