Re: [PATCH] media: imx219: fix test pattern ordering and add patterns

[Tharit Tangkijwanichakul]

>Yes please do so.

Thank you. I have sent the v3.

Best,
Tharit


On Wed, Jul 1, 2026 at 1:53 PM Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Tharit,
>
> Quoting Tharit Tangkijwanichakul (2026-06-26 18:08:20)
> > Hi Jai,
> >
> > Thanks for the review
> >
> > > Do you have a strong reason to switch this to the datasheet values?
> >
> > I must say there is no strong reason. I'm totally new here and come from
> > the perspective of someone studying how to write a camera sensor driver.
> > The datasheet says that writing 0x1 to reg 0x0601 will set the mode to solid
> > color test pattern. So it is "natural" to expect that I should set
> > test_pattern=1 to do so via v4l2-ctl.
> >
> > > I ask because this might break what userspace applications expect
> > > (libcamera) and also automated capture tests (that compare md5sums of the
> > > test pattern) in vendor board-farms.
> >
> > This was totally oblivious to me when I made the change.
> > I agree with you on this point. Breaking userspace does not sound like
> > a good idea.
> >
> > I'm open to making a v3 patch and only introduce new test patterns to
> > the driver.
> >
>
> Yes please do so.
>
> Thanks,
>     Jai
>
> > Best,
> > Tharit