Re: [PATCH v5 13/16] media: iris: Introduce buffer size calculations for AR50LT

[Dmitry Baryshkov]

On Wed, Jun 24, 2026 at 08:40:02PM +0530, Vikash Garodia wrote:
> 
> 
> On 6/16/2026 5:34 AM, Dmitry Baryshkov wrote:
> > From: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>
> > 
> > Introduces AR50LT  buffer size calculation for both encoder and
> > decoder. Reuse the buffer size calculation which are common, while
> > adding the AR50LT specific ones separately.
> > 
> > Signed-off-by: Dikshita Agarwal <dikshita.agarwal@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > ---
> >   drivers/media/platform/qcom/iris/iris_vpu_buffer.c | 401 +++++++++++++++++++++
> >   drivers/media/platform/qcom/iris/iris_vpu_buffer.h |  37 ++
> >   2 files changed, 438 insertions(+)
> > 
> > @@ -507,6 +734,13 @@ u32 hfi_buffer_line_vp9d(u32 frame_width, u32 frame_height, u32 _yuv_bufcount_mi
> >   	return _lb_size + vpss_lb_size + 4096;
> >   }
> > +static inline
> > +u32 hfi_buffer_line_vp9d_ar50lt(u32 frame_width, u32 frame_height, u32 _yuv_bufcount_min,
> > +				bool is_opb, u32 num_vpp_pipes)
> > +{
> > +	return hfi_ar50lt_vp9d_lb_size(frame_width, frame_height, num_vpp_pipes);
> 
> pls keep same name across like "hfi_buffer_line_vp9d_ar50lt" and
> "hfi_ar50lt_vp9d_lb_size" or combine these 2 apis, as the one just calls the
> other.

I think, Sashiko pointout a different issue here. Should I be calling
size_vpss_lb() to take is_opb into account?

> 
> > +}
> > +
> >   static u32 hfi_buffer_line_h264d(u32 frame_width, u32 frame_height,
> >   				 bool is_opb, u32 num_vpp_pipes)
> >   {

-- 
With best wishes
Dmitry