Re: [PATCH] kasan: include <linux/instruction_pointer.h> for _RET_IP_

[Vincenzo Frascino]

On 01/07/2026 08:04, Tao Cui wrote:
> From: Tao Cui <cuitao@xxxxxxxxxx>
> 
> kasan.h uses _RET_IP_ but relied on <linux/trace_printk.h>, included via
> <linux/kernel.h>, to provide it. Commit 9cbc3d9806d3 ("tracing: Remove
> trace_printk.h from kernel.h") dropped that transitive include, so files
> that don't otherwise get instruction_pointer.h no longer build, e.g.
> kernel/scs.c on arm64 KASAN:
> 
>   include/linux/kasan.h:199:43: error: use of undeclared identifier '_RET_IP_'
> 
> Include <linux/instruction_pointer.h> directly to make the dependency
> explicit.
> 
> Fixes: 9cbc3d9806d3 ("tracing: Remove trace_printk.h from kernel.h")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606301759.hTqHaPuI-lkp@xxxxxxxxx/
> Signed-off-by: Tao Cui <cuitao@xxxxxxxxxx>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@xxxxxxx>

> ---
>  include/linux/kasan.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/linux/kasan.h b/include/linux/kasan.h
> index bf233bde68c7..d5159c8033e8 100644
> --- a/include/linux/kasan.h
> +++ b/include/linux/kasan.h
> @@ -3,6 +3,7 @@
>  #define _LINUX_KASAN_H
>  
>  #include <linux/bug.h>
> +#include <linux/instruction_pointer.h>
>  #include <linux/kasan-enabled.h>
>  #include <linux/kasan-tags.h>
>  #include <linux/kernel.h>

-- 
Regards,
Vincenzo