Re: [PATCH 2/4] selftests: ntsync: fix wake_all CREATE_EVENT fd expectation

[Elizabeth Figura]

On Saturday, 27 June 2026 21:42:37 CDT Iván Ezequiel Rodriguez wrote:
> wake_all used EXPECT_EQ(0, objs[3]) after NTSYNC_IOC_CREATE_EVENT.
> The ioctl returns a non-negative file descriptor on success; check
> EXPECT_LE(0, objs[3]) like the other CREATE_* paths. The incorrect
> expectation was noted on list (Mar 2025) but is still present in
> mainline.
> 
> Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@xxxxxxxxx>
> ---
>  tools/testing/selftests/drivers/ntsync/ntsync.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/drivers/ntsync/ntsync.c b/tools/testing/selftests/drivers/ntsync/ntsync.c
> index e6a37214aa46..12b4b81edf7f 100644
> --- a/tools/testing/selftests/drivers/ntsync/ntsync.c
> +++ b/tools/testing/selftests/drivers/ntsync/ntsync.c
> @@ -968,7 +968,7 @@ TEST(wake_all)
>  	auto_event_args.manual = false;
>  	auto_event_args.signaled = true;
>  	objs[3] = ioctl(fd, NTSYNC_IOC_CREATE_EVENT, &auto_event_args);
> -	EXPECT_EQ(0, objs[3]);
> +	EXPECT_LE(0, objs[3]);
>  
>  	wait_args.timeout = get_abs_timeout(1000);
>  	wait_args.objs = (uintptr_t)objs;
> 

Reviewed-by: Elizabeth Figura <zfigura@xxxxxxxxxxxxxxx>

--

This was already sent as <https://lore.kernel.org/all/20250314071454.201697-2-suhui@xxxxxxxxxxxx/> and never committed.