Re: [PATCH v2 6/8] iio: adc: add ti-ads112c14 driver

[Jonathan Cameron]

On Thu, 25 Jun 2026 16:55:08 -0500
"David Lechner (TI)" <dlechner@xxxxxxxxxxxx> wrote:

> Add a new driver for the TI ADS112C14/ADS122C14 ADC chips.
> 
> This first step is adding a very basic driver that only supports power
> on/reset and reading the system monitor channels.
> 
> ADS112C14_SYS_MON_CHANNEL_SHORT is the last channel rather than being in
> logical order by address to keep the voltage channels together and in
> case we find we need to add variants of this channel with different
> voltage reference later.
> 
> Signed-off-by: David Lechner (TI) <dlechner@xxxxxxxxxxxx>

Really trivial comments below.

> diff --git a/drivers/iio/adc/ti-ads112c14.c b/drivers/iio/adc/ti-ads112c14.c
> new file mode 100644
> index 000000000000..c61d47244732
> --- /dev/null
> +++ b/drivers/iio/adc/ti-ads112c14.c
...

> +
> +	/* Write magic reset value (0x16) to ensure known state.*/

Space before */

> +	ret = regmap_write(data->regmap, ADS112C14_REG_CONVERSION_CTRL,
> +			   FIELD_PREP(ADS112C14_CONVERSION_CTRL_RESET, 0x16));

...

> +static const struct ads112c14_chip_info ads122c14_chip_info = {
> +	.name = "ads122c14",
> +	.resolution_bits = 24,

Might be a good idea to have expected stuff for DEVICE_ID in here
as well.  Whilst we don't want to reject a missmatch (for dt fallback)
reasons, it is nice to print if we see one as a hint something that might
be unexpected is going on.
> +};