Re: [PATCH] mm/mm_init: handle alloc_percpu failure in free_area_init_core_hotplug

[Mike Rapoport]

On Wed, Jul 01, 2026 at 11:20:50AM -0400, Gregory Price wrote:
> On Wed, Jul 01, 2026 at 09:38:57AM +0300, Mike Rapoport wrote:
> > On Tue, Jun 30, 2026 at 05:40:39PM -0400, Gregory Price wrote:
> > > We miss a failed allocation check for pgdat->per_cpu_nodestats, which
> > > results in a NULL deref when we offset into the per-cpu area.
> > > 
> > > Propagate -ENOMEM up the stack and leave per_cpu_nodestats pointing
> > > at boot_nodestats so a later online can retry the allocation.
> > > 
> > > hotadd_init_pgdat() returns NULL on failure, which __try_online_node()
> > > already maps to -ENOMEM.
> > > 
> > > Assisted-by: Sashiko:unknown-model
> > 
> > I suppose it's rather 
> > 
> > Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> 
> I honestly wasn't sure here, Assisted-by is the tag for LLMs lol
> i can change it

My understanding is that Assisted-by is for cases when you drive an LLM to
create the patch.

And Sashiko reports issues so I believe it should be attributed just as
kernel build robot with Reported-by.

-- 
Sincerely yours,
Mike.