Re: [PATCHv2 0/8] ata: sata_dwc_460ex: cleanups and interrupt ordering fix

[Damien Le Moal]

On 7/2/26 09:03, Rosen Penev wrote:
> This series modernizes the sata_dwc_460ex driver by replacing legacy OF
> APIs with their modern device-property and platform-device counterparts,
> converting old DMA resource teardown to devm-managed cleanup, fixing a
> latent interrupt-ordering bug, and dropping a redundant stack copy of
> port_info.
> 
> Patch 4 fixes a real issue: sata_dwc_enable_interrupts() was called
> before the IRQ handler was registered, so a probe failure or an
> asserted interrupt could trigger an unhandled irq storm.
> 
> v2: sashiko fixes.

Several patches in this series are clearly bug fixes that should come first in
the series and have a fixes tag and cc-stable. Can you please reorganize the
series with the fixes first ?

Also please try to avoid growing the patch series with more patches in response
to sachiko "not introduced by this patch" comments on valid problems. Send
incremental patches instead. Otherwise, making progress will take a longer time,
and bigger series are harder to review.

> 
> Rosen Penev (8):
>   ata: sata_dwc_460ex: use device_property_present()
>   ata: sata_dwc_460ex: use platform_get_irq()
>   ata: sata_dwc_460ex: enable SATA interrupts only after IRQ handler is
>     registered
>   ata: sata_dwc_460ex: drop redundant struct copy of port_info
>   ata: sata_dwc_460ex: fix data race on hsdev->sactive_issued in
>     interrupt handler
>   ata: sata_dwc_460ex: disable SATA interrupts on device removal
>   ata: sata_dwc_460ex: fix PHY lifecycle ordering on device removal
>   ata: sata_dwc_460ex: use devm for old DMA resource lifetime management
> 
>  drivers/ata/sata_dwc_460ex.c | 99 ++++++++++++++++++------------------
>  1 file changed, 49 insertions(+), 50 deletions(-)
> 
> --
> 2.55.0
> 


-- 
Damien Le Moal
Western Digital Research