Re: [PATCH] gpio: dwapb: Defer clock gating until noirq

[Jia Wang]

On 2026-06-29 18:04 +0800, kernel test robot wrote:
> Hi Jia,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on dc59e4fea9d83f03bad6bddf3fa2e52491777482]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Jia-Wang-via-B4-Relay/gpio-dwapb-Defer-clock-gating-until-noirq/20260629-135404
> base:   dc59e4fea9d83f03bad6bddf3fa2e52491777482
> patch link:    https://lore.kernel.org/r/20260629-gpio-dwapb-wakeup-v1-1-3394f02317da%40ultrarisc.com
> patch subject: [PATCH] gpio: dwapb: Defer clock gating until noirq
> config: sparc64-randconfig-001-20260629 (https://download.01.org/0day-ci/archive/20260629/202606291736.mAgOeA65-lkp@xxxxxxxxx/config)
> compiler: sparc64-linux-gcc (GCC) 8.5.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260629/202606291736.mAgOeA65-lkp@xxxxxxxxx/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202606291736.mAgOeA65-lkp@xxxxxxxxx/
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/gpio/gpio-dwapb.c: In function 'dwapb_irq_set_wake':
> >> drivers/gpio/gpio-dwapb.c:377:7: error: 'struct irq_data' has no member named 'parent_data'
>      if (d->parent_data && !!ctx->wake_en != !!wake_en) {
>           ^~
> >> drivers/gpio/gpio-dwapb.c:378:9: error: implicit declaration of function 'irq_chip_set_wake_parent'; did you mean 'irq_set_parent'? [-Werror=implicit-function-declaration]
>       err = irq_chip_set_wake_parent(d, enable);
>             ^~~~~~~~~~~~~~~~~~~~~~~~
>             irq_set_parent
>    cc1: some warnings being treated as errors
> 
> 
> vim +377 drivers/gpio/gpio-dwapb.c
> 
>    362	
>    363	static int dwapb_irq_set_wake(struct irq_data *d, unsigned int enable)
>    364	{
>    365		struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>    366		struct dwapb_gpio *gpio = to_dwapb_gpio(gc);
>    367		struct dwapb_context *ctx = gpio->ports[0].ctx;
>    368		irq_hw_number_t bit = irqd_to_hwirq(d);
>    369		u32 wake_en = ctx->wake_en;
>    370		int err;
>    371	
>    372		if (enable)
>    373			wake_en |= BIT(bit);
>    374		else
>    375			wake_en &= ~BIT(bit);
>    376	
>  > 377		if (d->parent_data && !!ctx->wake_en != !!wake_en) {
>  > 378			err = irq_chip_set_wake_parent(d, enable);
>    379			if (err)
>    380				return err;
>    381		}
>    382	
>    383		ctx->wake_en = wake_en;
>    384	
>    385		return 0;
>    386	}
>    387	
>

Thanks for the report. This is caused by using hierarchical IRQ helpers
without guarding them with CONFIG_IRQ_DOMAIN_HIERARCHY.

I'll fix this in the next version of the patch.
 
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>