Re: [PATCH] ALSA: pcm: Drop reduntant nonseekable_open() return check
From: Bui Duc Phuc
Date: Thu Jul 02 2026 - 04:41:41 EST
Hi Takashi-san,
Thank you for your review!
> > struct snd_pcm *pcm;
> > int err = nonseekable_open(inode, file);
> > - if (err < 0)
> > - return err;
> > +
>
> We don't have to assign err here, right?
> Keeping it looks rather confusing.
>
> I see a similar pattern in your other patches. Please try to address
> it and resubmit -- at best, as a v2 series of patches.
>
I'll update the patches accordingly and send a v2 patch series shortly.
Best regards,
Phuc