Re: [PATCH 4/4] arm64: dts: qcom: Enable SD card for Glymur CRD

[Monish Chunara]

On 6/12/2026 11:37 AM, Dmitry Baryshkov wrote:
> On Wed, Jun 10, 2026 at 04:45:08PM +0530, Monish Chunara wrote:
>> From: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>>
>> Enable SD card for Glymur CRD platform. Configure the vmmc/vqmmc
>> regulators and gpio-based card detection for the platform.
>>
>> Co-developed-by: Sachin <ssachin@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Sachin <ssachin@xxxxxxxxxxxxxxxx>
>> Signed-off-by: Monish Chunara <monish.chunara@xxxxxxxxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/glymur-crd.dts | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts
>> index c98dfb3941fa..f68d27429440 100644
>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts
>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts
>> @@ -427,3 +427,28 @@ &usb_mp_qmpphy1 {
>>  
>>  	status = "okay";
>>  };
>> +
>> +&sdhc_2 {
> 
> The board file should be sorted by the name. So these two entries are
> wrongly placed. sdhc_2 < usb_mp_qmpphy1.
> 
>> +	vmmc-supply = <&vreg_l9b_e0_2p9>;
>> +	vqmmc-supply = <&vreg_l2b_e0_2p9>;
>> +
> 

ACK.

Regards,
Monish