Re: [RFC PATCH 11/15] KVM: TDX: Factor out userspace return path from tdx_get_quote()

[Nikolay Borisov]

On 5/22/26 06:41, Xu Yilun wrote:
> From: Peter Fang <peter.fang@xxxxxxxxx>
>
> Separate the logic that returns GetQuote to userspace so that
> tdx_get_quote() can be extended to support in-kernel quote generation.
>
> No functional change intended.
>
> Signed-off-by: Peter Fang <peter.fang@xxxxxxxxx>
> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxxxxxxxx>
> ---
>   arch/x86/kvm/vmx/tdx.c | 25 ++++++++++++++++---------
>   1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/tdx.c b/arch/x86/kvm/vmx/tdx.c
> index ed12805bbb44..9f7c39e0d4b5 100644
> --- a/arch/x86/kvm/vmx/tdx.c
> +++ b/arch/x86/kvm/vmx/tdx.c
> @@ -1524,6 +1524,20 @@ static int tdx_complete_simple(struct kvm_vcpu *vcpu)
>   	return 1;
>   }
>   
> +static int tdx_get_quote_user(struct kvm_vcpu *vcpu, u64 gpa, u64 size)
> +{
nit: Function name is misleading, imo appropriate name should have 
"fill"/"init" in the name as what it does is to fill the run->tdx 
structure.


tdx_fill_quote_user/tdx_init_quote_user


> +	vcpu->run->exit_reason = KVM_EXIT_TDX;
> +	vcpu->run->tdx.flags = 0;
> +	vcpu->run->tdx.nr = TDVMCALL_GET_QUOTE;
> +	vcpu->run->tdx.get_quote.ret = TDVMCALL_STATUS_SUBFUNC_UNSUPPORTED;
> +	vcpu->run->tdx.get_quote.gpa = gpa;
> +	vcpu->run->tdx.get_quote.size = size;
> +
> +	vcpu->arch.complete_userspace_io = tdx_complete_simple;
> +
> +	return 0;
> +}
> +


<snip>