Re: [PATCH 13/32] x86/featctl: Stop using 32-bit MSR interfaces

[Jürgen Groß]

On 02.07.26 11:39, Ingo Molnar wrote:
> * Juergen Gross <jgross@xxxxxxxx> wrote:
>
> > -	rdmsr(MSR_IA32_VMX_PROCBASED_CTLS, ign, supported);
> > -	c->vmx_capability[PRIMARY_CTLS] = supported;
> > +	rdmsrq(MSR_IA32_VMX_PROCBASED_CTLS, val.q);
> > +	c->vmx_capability[PRIMARY_CTLS] = val.h;
>
> Please keep the original assignment that puts this into the
> 'supported' variable - which semi-documents the meaning of this
> field - even though its use is arguably minimal:
>
> 	rdmsrq(MSR_IA32_VMX_PROCBASED_CTLS, val.q);
> 	supported = val.h;
> 	c->vmx_capability[PRIMARY_CTLS] = supported;
>
> > -	rdmsr_safe(MSR_IA32_VMX_PROCBASED_CTLS2, &ign, &supported);
> > -	c->vmx_capability[SECONDARY_CTLS] = supported;
> > +	rdmsrq_safe(MSR_IA32_VMX_PROCBASED_CTLS2, &val.q);
> > +	c->vmx_capability[SECONDARY_CTLS] = val.h;

Fine with me.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature