Re: [PATCH 1/4] PM: runtime: Clear runtime_error on supplier after failed get_sync

[Rafael J. Wysocki (Intel)]

On Thu, Jul 2, 2026 at 8:08 AM Praveen Talari
<praveen.talari@xxxxxxxxxxxxxxxx> wrote:
>
> When pm_runtime_get_sync() fails for a supplier device in
> rpm_get_suppliers(), the supplier's power.runtime_error field is left
> set. This causes any subsequent rpm_resume() call on that supplier to
> immediately return -EINVAL at the top of the function without
> attempting an actual resume, making the failure permanent until
> runtime PM is explicitly re-enabled.
>
> Fix this by calling pm_runtime_set_suspended() on the supplier after
> pm_runtime_put_noidle() in the error path. This clears runtime_error
> and resets the runtime PM status to RPM_SUSPENDED, allowing the next
> consumer resume attempt to retry the supplier resume normally.
>
> Change-Id: Id5067d09caca464f663fc95fe745d037e9c56664
> Signed-off-by: Praveen Talari <praveen.talari@xxxxxxxxxxxxxxxx>
> ---
>  drivers/base/power/runtime.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c
> index 335288e8b5b3..9811d024d140 100644
> --- a/drivers/base/power/runtime.c
> +++ b/drivers/base/power/runtime.c
> @@ -309,6 +309,7 @@ static int rpm_get_suppliers(struct device *dev)
>                 /* Ignore suppliers with disabled runtime PM. */
>                 if (retval < 0 && retval != -EACCES) {
>                         pm_runtime_put_noidle(link->supplier);
> +                       pm_runtime_set_suspended(link->supplier);
>                         return retval;
>                 }
>                 refcount_inc(&link->rpm_active);
>
> --

I don't think that this is the way to go here.

Can you please say some more about the specific scenario in which this
happens and explain why it is OK to effectively discard runtime PM
errors occurring when suppliers are handled?