Re: [PATCH v3] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Dmitry Baryshkov]

On Thu, Jul 02, 2026 at 04:25:09PM +0530, Sarat Addepalli wrote:
> Add IPA nodes for Qualcomm qcm6490 board.
> 
> The qcom,gsi-loader and memory-region properties are provided by
> kodiak.dtsi as part of the IPA property consolidation work, so only
> the board-specific firmware-name and status properties need to be set.
> 
> Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@xxxxxxxxxxxxxxxx/
> 
> Signed-off-by: Sarat Addepalli <sarat.addepalli@xxxxxxxxxxxxxxxx>

No empty lines between tags. Also please don't post new revisions of the
patches as replies to earlier series. Always start a new thread. It's
documented under Documentation/process/

> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++
>  1 file changed, 5 insertions(+)

Missing changelog between patch iterations. Please fix it for the next
revision.

> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..d4f96bdd3a90 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,11 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +	status = "okay";

Empty line before the status property, please.

> +};
> +
>  &lpass_rx_macro {
>  	status = "okay";
>  };

-- 
With best wishes
Dmitry