Re: [PATCH v2] firmware: stratix10-svc: fix FCS SMC call kernel-doc

From: Dinh Nguyen

Date: Thu Jul 02 2026 - 08:17:47 EST


Hi Genevieve,

On 7/2/26 03:28, genevieve.chan@xxxxxxxxxx wrote:
From: Genevieve Chan <genevieve.chan@xxxxxxxxxx>

Correct kernel-doc errors for two FCS SMC calls:

INTEL_SIP_SMC_FCS_SEND_CERTIFICATE:
- Describe as async to match STD_CALL_VAL usage
- Replace INTEL_SIP_SMC_FCS_REJECTED with INTEL_SIP_SMC_REJECTED

INTEL_SIP_SMC_FCS_GET_PROVISION_DATA:
- Replace FCS-specific status macros with standard status macros
(INTEL_SIP_SMC_STATUS_ERROR and INTEL_SIP_SMC_STATUS_REJECTED)
- Restore return register documentation for a1 (mailbox error),
a2 (physical address), and a3 (structure size)

Fixes: 4a4709d470e624e65a879b5c430dee5e27e9ac83 ("firmware: stratix10-svc: add new FCS commands")
Fixes: 4b0a32016347bfd6ae9849f21b1b767905f68d14 ("firmware: stratix10-svc: change get provision data to async SMC call")

Just use 12 characters of the commit hash in the Fixes tag please.

Cc: stable@xxxxxxxxxxxxxxx # 7.2+: commit 4b0a32016347bfd6ae9849f21b1b767905f68d14 ("firmware: stratix10-svc: change get provision data to async SMC call")

7.2 is not released yet. Please remove this line.

Cc: stable@xxxxxxxxxxxxxxx # 6.0

This is confusing, you probably want 6.0+, right?

When unclear about your Signed-off's, take a look at similar commits, mailing list, and provided documents.

Thank,
Dinh