Re: [PATCH v3 1/2] iio: adc: ad7779: Remove unused completion field

[Jonathan Cameron]

On Thu, 2 Jul 2026 13:54:28 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Thu,  2 Jul 2026 11:46:48 +0000
> Moksh Panicker <mokshpanicker.7@xxxxxxxxx> wrote:
> 
> > struct ad7779_state contains a completion field that is initialized
> > in ad7779_setup_without_backend() but never waited on or signaled
> > anywhere in the driver. Remove the dead code.
> > 
> > Suggested-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
> > Signed-off-by: Moksh Panicker <mokshpanicker.7@xxxxxxxxx>
> > ---
> >  drivers/iio/adc/ad7779.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/ad7779.c b/drivers/iio/adc/ad7779.c
> > index 695cc79e78da..c1a99b4c1256 100644
> > --- a/drivers/iio/adc/ad7779.c
> > +++ b/drivers/iio/adc/ad7779.c
> > @@ -143,7 +143,6 @@ struct ad7779_state {
> >  	const struct ad7779_chip_info *chip_info;
> >  	struct clk *mclk;
> >  	struct iio_trigger *trig;
> > -	struct completion completion;
> >  	unsigned int sampling_freq;
> >  	enum ad7779_filter filter_enabled;
> >  	struct iio_backend *back;
> > @@ -852,7 +851,6 @@ static int ad7779_setup_without_backend(struct ad7779_state *st, struct iio_dev
> >  
> >  	indio_dev->trig = iio_trigger_get(st->trig);
> >  
> > -	init_completion(&st->completion);
> >    
> 
> Remove the blank line here as well.
Fixed up and applied.

> 
> >  	ret = devm_iio_triggered_buffer_setup(dev, indio_dev,
> >  					      &iio_pollfunc_store_time,  
> 
> 
>