Re: [PATCH v15 4/4] crypto: spacc - Add SPAcc Kconfig and Makefile

From: Julian Braha

Date: Thu Jul 02 2026 - 15:19:13 EST


Hi Pavitrakumar,

On 7/1/26 13:29, Pavitrakumar Managutte wrote:

> +config CRYPTO_DEV_SPACC_DEBUG_TRACE_IO
> + bool "Enable Trace MMIO reads/writes stats"
> + default n
> + help
> + Say y to enable Trace MMIO reads/writes stats.
> + To Debug and trace IO register read/write oprations.
> +

Typo in "operations".

> +config CRYPTO_DEV_SPACC_DEBUG_TRACE_DDT
> + bool "Enable Trace DDT entries stats"
> + default n
> + help
> + Say y to enable Enable DDT entry stats.
> + To Debug and trace DDT opration

Another typo in "operation".

> +
> +config CRYPTO_DEV_SPACC_CONFIG_DEBUG
> + bool "Enable SPAcc debug logs"
> + default n
> + help
> + Say y to enable additional debug prints and diagnostics in the

Most of your kconfig formatting looks okay, but you strangely have 8
spaces here in your help text.

- Julian Braha