Re: [PATCH v4 4/6] irqchip/gic-v3-its: Add ITS address info in more error logs

From: Marc Zyngier

Date: Thu Jul 02 2026 - 18:08:41 EST


On Thu, 02 Jul 2026 04:30:48 +0100,
Kemeng Shi <shikemeng@xxxxxxxxxxxxxxx> wrote:
>
> Multiple ITS units may exist in a system. When an error occurs, it is
> difficult to identify which ITS triggered it because most error logs
> lack the ITS address. Some logs already include this information and
> is useful for debugging. Add the ITS address to the remaining error
> logs so that all ITS-related errors can be consistently attributed to
> a specific ITS instance.

I already said *no* to this.

If you want to log errors, implement a PMU or RAS driver that reports
errors on a per ITS basis, in a way that is collectable by existing
tooling.

The kernel log is not the place for your sorry debug hacks, which is
in general not readable by normal users. And I'd rather remove the
other instances as a matter of consistency.

M.

--
Jazz isn't dead. It just smells funny.