Re: [PATCH 3/4] USB: gadget: fsl-udc: fix dev_printk() device

From: Uwe Kleine-König

Date: Thu Jul 02 2026 - 18:39:48 EST


Hello Johan,

On Thu, Jul 02, 2026 at 04:15:35PM +0200, Johan Hovold wrote:
> A change replacing custom printk() macros with dev_printk() incorrectly
> used the gadget struct device instead of the controller struct device
> (including for messages printed before the gadget device name has been
> initialised).
>
> Switch to using the controller platform device with dev_printk() so that
> the controller device and driver names are included in log messages as
> expected.

I don't know about "expected", because before 6025f20f16c2 the affected
device wasn't included in the message at all. But I agree that using the
not yet initialized device isn't nice, so:

Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

Thanks
Uwe

Attachment: signature.asc
Description: PGP signature