Re: [PATCH v6 08/16] dt-bindings: iio: frequency: add ad9910

[Jonathan Cameron]

> > +  '#clock-cells':
> > +    const: 1
> > +
> > +  clock-output-names:
> > +    minItems: 1
> > +    maxItems: 3
> > +    items:
> > +      enum: [ sync_clk, pdclk, sync_out ]


> > +dependencies:
> > +  adi,charge-pump-current-microamp: [ 'adi,pll-enable' ]
> > +  adi,refclk-out-drive-strength: [ 'adi,pll-enable' ]
> > +  lock-detect-gpios: [ 'adi,pll-enable' ]
> > +  interrupts: [ interrupt-names ]
> > +  clocks: [ clock-names ]  
> 
> As clocks is required below, then 'clock-names' is also always required.
> 
> > +  '#clock-cells': [ clock-output-names ]  
> 
> The h/w sometimes has clock outputs and sometimes doesn't? #clock-cells 
> should always be required IMO.

In this case, yup, required is fair enough, but more generally it
isn't uncommon to have a pin that is either a clock output or something
entirely different (often an input). Though in that case I'd expect a
check to make the two cases mutually exclusive.

Here they are always output clocks so required is fine.