Re: [PATCH v2 2/2] iio: temperature: Add STS30 temperature sensor driver
From: Joshua Crofts
Date: Fri Jul 03 2026 - 02:43:03 EST
On Fri, 3 Jul 2026 00:31:59 +0100
Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> On Sun, 21 Jun 2026 19:09:11 -0500
> Maxwell Doose <m32285159@xxxxxxxxx> wrote:
>
> > On Sun, Jun 21, 2026 at 7:05 PM Maxwell Doose <m32285159@xxxxxxxxx> wrote:
> > >
> > > On Sun, Jun 21, 2026 at 1:33 PM Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:
> > > >
> > > > On Sat, 20 Jun 2026 19:46:24 -0500
> > > > Maxwell Doose <m32285159@xxxxxxxxx> wrote:
> > > > > +#include <linux/array_size.h>
> > > > > +#include <linux/bits.h>
> > > > > +#include <linux/cleanup.h>
> > > > > +#include <linux/crc8.h>
> > > > > +#include <linux/delay.h>
> > > > > +#include <linux/device.h>
> > > > > +#include <linux/errno.h>
> > > > > +#include <linux/export.h>
> > > > > +#include <linux/i2c.h>
> > > >
> > > > I am a numpty as I also forgot to mention a missing
> > > > mod_devicetable.h header.
> > > >
> > >
> > > D'oh, I ought to look at my includes a lot more closely as well.
> >
> > Forgot to mention, I'll be away for 2 weeks starting tomorrow so it'll
> > have to wait :(
>
> Don't add mod_devicetable.h. There is a series from Uwe that splits that header
> up and puts the tables different headers. i2c.h is now enough.
> (It's causing merge conflicts)
Cool, one include less to worry about.
--
Kind regards
CJD