Re: [PATCH v5 06/19] clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model
From: Konrad Dybcio
Date: Fri Jul 03 2026 - 03:17:36 EST
On 7/2/26 8:31 PM, Imran Shaik wrote:
> Update the QCM2290 DISPCC driver to use the qcom_cc_probe() model by moving
> the critical clocks handling and PLL configurations from probe to the
> driver_data to align with the latest convention.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> ---
[...]
> static const struct qcom_cc_desc disp_cc_qcm2290_desc = {
> .config = &disp_cc_qcm2290_regmap_config,
> .clks = disp_cc_qcm2290_clocks,
> @@ -498,6 +515,7 @@ static const struct qcom_cc_desc disp_cc_qcm2290_desc = {
> .num_gdscs = ARRAY_SIZE(disp_cc_qcm2290_gdscs),
> .resets = disp_cc_qcm2290_resets,
> .num_resets = ARRAY_SIZE(disp_cc_qcm2290_resets),
> + .driver_data = &disp_cc_qcm2290_driver_data,
> };
Now that this clock controller takes a power domain, this needs use_rpm
= true, or there will be a permanent 'enable' vote
Konrad