Re: [PATCH v3 4/8] irqchip/qcom-pdc: Differentiate between direct SPI and GPIO as SPI

From: Maulik Shah (mkshah)

Date: Fri Jul 03 2026 - 04:33:03 EST




On 6/30/2026 8:27 PM, Thomas Gleixner wrote:
> On Tue, Jun 16 2026 at 14:55, Maulik Shah wrote:
>> Before commit 4dc70713dc24 ("irqchip/qcom-pdc: Kill non-wakeup irqdomain")
>> there are separate domains for direct SPIs and GPIO used as SPIs. Separate
>
> s/are/were/

Sure. I will update in v4.

>
>> domains can be useful in case irqchip want to differentiate both of them.
>
> the irqchip wants

Sure. I will update in v4.

>
>> Since commit unified both the domains there is no way to differentiate.
>
> Since the commit.

Sure. I will update in v4.

>
>> In preparation to add the second level interrupt controller support where
>> GPIO interrupts get latched at PDC (but not direct SPIs) there is a need to
>> differentiate between SPIs and GPIOs as SPIs. Reverting above commit do not
>
> does not

Sure. I will update in v4.

>
>> seem a good option either which leads to waste of resources.
>
> 'either which leads' is not a parseable sentence.
>

Sure. I will update in v4.

Thanks,
Maulik