Re: [PATCH v1 0/4] gpio: regmap: Keep tracking IRQ requests and releases
From: Bartosz Golaszewski
Date: Fri Jul 03 2026 - 04:40:34 EST
On Fri, 3 Jul 2026 10:17:04 +0200, "Yu-Chun Lin [林祐君]"
<eleanor.lin@xxxxxxxxxxx> said:
> Hi Andy,
>
> Thanks for your patches!
>
>> During the review of the v3 [1] of the series that adds a driver for Realtek DHC
>> RTD1625 SoC GPIO the gap in the GPIO regmap implementation has been
>> discovered, id est the IRQ chip that is created by regmap IRQ doesn't have IRQ
>> request and release callbacks and hence in terms of GPIO does not track if any
>> line is locked as IRQ. This might lead to undesired and most likely faulty
>> behaviour. This series is to fill that gap. Currently it only fixes the only user of
>> the automatic IRQ chip creation facility provided by GPIO regmap, but also
>> provides the exported callbacks for others to be possible to call them from
>> customised versions of the callbacks in the respective drivers.
>>
>> Most of the affected drivers if I am not mistaken are the Industrial PC104 ones,
>> hence I Cc'ed William to look at this and perhaps even test.
>>
>> Yu-Chun, can you give a try with your v3 based on this series? I believe we can
>> use regmap approach after all.
>>
>
> I tested them on the rtd1625 SoC board and it looks good. If no one else
> has any issues with Andy's patch series, I'll send out v6, which will be
> based on my v3 and this series.
>
Please just fold Andy's patches into your series for easier review.
Thanks,
Bartosz