Re: [PATCH] kbuild: unset sub_make_done before calling kselftest build system
From: Petr Mladek
Date: Fri Jul 03 2026 - 04:45:58 EST
On Fri 2026-07-03 08:04:08, Thomas Weißschuh wrote:
> The kselftest build system may recourse back into kbuild when building
> test modules. In that case kbuild needs to parse the new flags passed
> from the command line, instead of using the ones inherited from the
> kbuild invocation.
>
> Force that command line reevaluation.
>
> The same was done for scripts/install.sh in commit 14ccc638b02f9ec
> ("kbuild: cancel sub_make_done for the install target to fix DKMS")
>
> Reported-by: Zelin Deng <zelin.deng@xxxxxxxxxxxxxxxxx>
> Closes: https://lore.kernel.org/all/20260525083721.27857-1-zelin.deng@xxxxxxxxxxxxxxxxx/
It is great that you added references to the related commit and
the original thread.
> Fixes: c9bb03ac2c66 ("kbuild: reduce output spam when building out of tree")
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
I believe that this is reasonable solution:
Acked-by: Petr Mladek <pmladek@xxxxxxxx>
Zelin, could you please provide your Tested-by, please?
Best Regards,
Petr
PS: I could take this via livepatching tree. But feel free to take it
via kbuild tree. I am going to wait few days until the discussion
settles down.