Re: [PATCH net] bnge/bng_re: fix ring ID widths

[Vikas Gupta]

On Fri, Jul 3, 2026 at 1:03 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote:
>
> On 6/30/26 12:15 PM, Vikas Gupta wrote:
> > diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> > index 341c7f81ed09..bb0c79a1ee60 100644
> > --- a/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> > +++ b/drivers/net/ethernet/broadcom/bnge/bnge_rmem.h
> > @@ -184,7 +184,7 @@ struct bnge_ctx_mem_info {
> >  struct bnge_ring_struct {
> >       struct bnge_ring_mem_info       ring_mem;
> >
> > -     u16                     fw_ring_id;
> > +     u32                     fw_ring_id;
>
> Sashiko gemini has a few concerns about the id size increases:
>
> https://sashiko.dev/#/patchset/20260630101554.1221733-1-vikas.gupta%40broadcom.com
>
> please have a look.
Sashiko's concern about backward compatibility is valid, however, the
driver is not expected to work with older firmware because the Thor
Ultra device has not been deployed yet.

The concern about overlapping bits is also valid, but the firmware
uses a ring ID with a maximum width of 18 bits, so no overlap occurs.
Nevertheless, I will add a mask for xid to improve code clarity and
readability.

Thanks,
Vikas


>
>
> /P
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature