Re: [PATCH v2 0/7] ALSA: Remove redundant open helper return checks

[Takashi Iwai]

On Thu, 02 Jul 2026 10:44:37 +0200,
phucduc.bui@xxxxxxxxx wrote:
> 
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> 
> Hi all,
> 
> This series removes redundant error checks after calls to
> nonseekable_open() and stream_open() in the ALSA core.
> 
> nonseekable_open() always returns 0, so checking its return value is
> unnecessary.
> 
> Several users were later converted from nonseekable_open() to
> stream_open(), but the original error checks were retained.
> Since stream_open() also always returns 0, those checks are likewise
> unnecessary.
> 
> As a result, all patches simply remove dead error handling paths with no
> functional change.
> 
> Change in v2 : 
>  - Drop the unnecessary assignment of the return value from
>    nonseekable_open()/stream_open(), as suggested by Takashi.
>  - Merge the individual patches into a single patch series.
> 
> Best regards,
> Phuc
> 
> bui duc phuc (7):
>   ALSA: control: Drop redundant stream_open() return check
>   ALSA: mixer: oss: Drop redundant nonseekable_open() return check
>   ALSA: pcm: oss: Drop redundant nonseekable_open() return check
>   ALSA: pcm: Drop redundant nonseekable_open() return check
>   ALSA: rawmidi: Drop redundant stream_open() return check
>   ALSA: seq: Drop redundant stream_open() return check
>   ALSA: timer: Drop redundant stream_open() return check

Applied all patches to for-next branch now.  Thanks.


Takashi