Re: [PATCH v1 00/10] platform/x86: Stop using acpi_device_name/class()
From: Rafael J. Wysocki (Intel)
Date: Fri Jul 03 2026 - 08:24:48 EST
On Fri, Jul 3, 2026 at 2:19 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> On Fri, Jul 03, 2026 at 03:10:26PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 03, 2026 at 01:15:01PM +0200, Rafael J. Wysocki wrote:
> > > Hi All,
> > >
> > > There are two fields in struct acpi_device_pnp, device_name and device_class,
> > > that were supposed to be populated and used by device drivers, but they have
> > > never been used consistently and some drivers just populate them and don't
> > > access them later, and some drivers use them uninitialized.
> > >
> > > All of that is confusing and messy, so the drivers for core ACPI devices
> > > have been updated to stop using those fields which are now slated for
> > > removal, but they are still accessed in some places.
> > >
> > > This series updates platform x86 drivers accessing those fields to stop
> > > doing that.
> >
> > In most of the patches you have double space in your name in From. Can we have
> > some consistency here? Or is it deliberate (in which case I'm wondering why)?
>
> I looked into all patches and I see them good.
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!
> (with preferably used same From field across the patches).
What goes into commits is the one in the patch body (which overrides
the one in the SMTP headers), so it is the same.
The one in the SMTP headers has indeed been messed up by the email
client, but it doesn't really matter.