Re: [PATCH v2 0/4] platform/x86/amd/hsmp: ACPI input hardening and data-plane readiness gating

From: Ilpo Järvinen

Date: Fri Jul 03 2026 - 09:17:41 EST


On Mon, 29 Jun 2026 21:26:30 +0530, Muralidhara M K wrote:

> This series hardens the AMD HSMP ACPI driver against malformed firmware
> and fixes a data-plane readiness race on multi-socket systems. It is
> split out and reworked from the larger HSMP concurrency series.
>
> Patches 1-2 validate ACPI input before it is used:
>
> - hsmp_get_uid() passed the device UID straight to kstrtou16(uid + 2)
> without checking it; a NULL or too-short UID could dereference NULL
> or read past the end of the string.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent or clearly a regression fix.

The list of commits applied:
[1/4] platform/x86/amd/hsmp: Validate ACPI UID before parsing socket index
commit: f820f61f079ad50869cee6541bbb6423f88536b7
[2/4] platform/x86/amd/hsmp: Validate _DSD mailbox sub-package element count
commit: 1cacf5e8693dd1053d9044b6e6e4986bbbd355a1
[3/4] platform/x86/amd/hsmp: Pass struct device explicitly to ACPI mailbox parsers
commit: 0c963c5b4d68922f6fa2c120fde7a4fecc0ab46d
[4/4] platform/x86/amd/hsmp: Gate the data plane on a fully initialized socket
commit: ff7836fa850c2f815bc219f1e48f6ec8699f4ae7

--
i.