Re: [PATCH net-next v2 3/3] af_unix: Clean up error handling in unix_listen()
From: Christian Brauner
Date: Fri Jul 03 2026 - 09:23:03 EST
> To avoid the sort of bug that was just fixed going forward, switch to a
> style where `err = -E...;` instead happens right before the `goto`.
> (`err = other_function(...);` is not changed.) Then there is no
> spooky-action-at-a-distance between the `err` initialization and the
> `goto`, something which is easier to slip by code review.
>
> Signed-off-by: John Ericson <mail@xxxxxxxxxxxxxx>
Reviewed-by: Christian Brauner (Amutable) <brauner@xxxxxxxxxx>
--
Christian Brauner <brauner@xxxxxxxxxx>