Re: [PATCH v5 04/18] mm: Split out internal page_alloc.h

[Zi Yan]

On Fri Jul 3, 2026 at 8:31 AM EDT, Brendan Jackman wrote:
> internal.h is a bit bloated, seems like time for a page_alloc.h.
>
> Where it wasn't obvious, the heuristic for deciding what goes into this
> new header was "does it support/correspond to a definition in
> mm/page_alloc.c?"
>
> Only need to include it from ~20 .c files out of ~150 so this does seem
> like a genuine reduction in scopes, which is nice. And there's no
> circular internal.h<->page_alloc.h dependency, so it seems worthwhile to
> split this up before that inevitably emerges!
>
> Suggested-by: "David Hildenbrand (Arm)" <david@xxxxxxxxxx>
> Link: https://lore.kernel.org/all/41e92bab-6882-401a-8de9-154adbdcfb36@xxxxxxxxxx/
> Reviewed-by: Vlastimil Babka (SUSE) <vbabka@xxxxxxxxxx>
> Signed-off-by: Brendan Jackman <jackmanb@xxxxxxxxxx>
> ---
>  MAINTAINERS          |   1 +
>  mm/compaction.c      |   1 +
>  mm/hugetlb.c         |   1 +
>  mm/internal.h        | 252 -----------------------------------------------
>  mm/khugepaged.c      |   1 +
>  mm/kmsan/init.c      |   2 +-
>  mm/memory-failure.c  |   1 +
>  mm/memory_hotplug.c  |   1 +
>  mm/mempolicy.c       |   1 +
>  mm/migrate.c         |   1 +
>  mm/mm_init.c         |   1 +
>  mm/page_alloc.c      |   1 +
>  mm/page_alloc.h      | 269 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  mm/page_frag_cache.c |   2 +-
>  mm/page_isolation.c  |   1 +
>  mm/page_owner.c      |   2 +-
>  mm/page_reporting.c  |   1 +
>  mm/show_mem.c        |   1 +
>  mm/shuffle.c         |   1 +
>  mm/slub.c            |   1 +
>  mm/swap.c            |   1 +
>  mm/vmscan.c          |   1 +
>  22 files changed, 289 insertions(+), 255 deletions(-)
>
Thank you for the cleanup.

Acked-by: Zi Yan <ziy@xxxxxxxxxx>

-- 
Best Regards,
Yan, Zi