Re: [PATCH v2] net/9p: add vsock transport

From: Stefano Garzarella

Date: Fri Jul 03 2026 - 10:43:56 EST


On Fri, Jul 03, 2026 at 04:31:25PM +0200, skvarlamatus@xxxxxxxxx wrote:
On Fri, Jul 03, 2026 at 09:12 +0000, sgarzare@xxxxxxxxxx wrote:
>The privport mount option is not currently supported for vsock and
>returns -EOPNOTSUPP if specified.

Why not?

The existing p9_bind_privport() implementation is TCP-specific
(uses inet_pton and struct sockaddr_in), so it cannot be reused
for vsock directly. Per Stefan Hajnoczi's suggestion, I opted to
reject the option cleanly for now rather than leave it silently

Ah, I see now. Sorry, I didn't look at the v1.

ignored. Support can be added in a follow-up if needed.

I'd add a comment in the code to explain that, maybe with a TODO label. Because initially I thought it was not applicable to AF_VSOCK sockets for some reason related to he socket family.

Thanks,
Stefano