Re: [PATCH rtw-next v3] wifi: rtw89: check return values in rtw89_ops_start_ap()

From: d . morgun

Date: Fri Jul 03 2026 - 11:54:14 EST


Hi Ping-Ke,

Sorry for the confusion. The v3 suffix was added by mistake during local iterations of the patch.

There is no public v1/v2 in the mailing list history. This is the first version submitted upstream.

I will resend as v1 if needed.

Best regards,
Dmitry

Ping-Ke Shih писал(а) 2026-06-30 03:27:
Dmitry Morgun <d.morgun@xxxxxxxxx> wrote:
Subject: [PATCH rtw-next v3] wifi: rtw89: check return values in rtw89_ops_start_ap()

Patch is fine. But I don't remember why this is v3. Can you point out
v1 and v2?

Several functions called in rtw89_ops_start_ap() may fail to allocate
skb or fail to send H2C command to firmware, returning -ENOMEM or an
error code. Their return values are ignored, so subsequent commands
are executed with incorrect state.

Check the return values and propagate errors.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: a52e4f2ce0f5 ("wifi: rtw89: implement ieee80211_ops::start_ap and stop_ap")
Signed-off-by: Dmitry Morgun <d.morgun@xxxxxxxxx>

Acked-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>