Re: [PATCH v2] rust: iommu: add device lifetime to IoPageTable

From: Deborah Brouwer

Date: Fri Jul 03 2026 - 19:58:40 EST


On Fri, Jul 03, 2026 at 09:37:53PM +0200, Danilo Krummrich wrote:
> On Fri Jul 3, 2026 at 8:52 PM CEST, Deborah Brouwer wrote:
> > +impl<'bound, F: IoPageTableFmt> IoPageTable<'bound, F> {
>
> We settled on the convention to only call a lifetime 'bound when it actually
> described the entire bound scope. This might be shorter lived, so maybe just 'a.

Ack.

>
> > + // TODO: Provide the option to return `IoPageTable` as a device resource
> > + // when DevresLt is available.
>
> I'd drop this comment, we only really need it once there's a justified use-case,
> or do you have something in mind already?

Sure, I will drop the comment. I don't have a particular use case in mind.
Tyr will own the page table through its VM data, so with the lifetime tied
to the bound device there is no need for Tyr to use devres.