Re: [PATCH v6 11/12] reset: zte: Add a zx297520v3 reset driver

[Stefan Dösinger]

Hi,

Am Freitag, 3. Juli 2026, 12:16:09 Ostafrikanische Zeit schrieb Philipp Zabel:
> On Do, 2026-07-02 at 23:28 +0300, Stefan Dösinger wrote:

> > +	rst->map = device_node_to_regmap(of_node);
> > +	if (IS_ERR(rst->map))
> > +		return dev_err_probe(dev, PTR_ERR(rst->map), "Cannot get 
parent syscon
> > regmap\n");
> Does your parent even have to be a syscon?
> 
> Could you just create the regmap in the MFD driver and use
> dev_get_regmap(pdev->dev.parent, NULL) here?

topcrm needs to be a syscon: It has control bits that the watchdog driver will 
need to access

lspcrm no. I am convinced it only has clocks and resets

matrixcrm is yet to be decided. It is involved in the mailbox system to read 
RAM properties together with the dedicated RAM controller, but I need to do 
more investigation. I might drop the syscon depending on the outcome.

Afaiu device_node_to_regmap is supposed to work on on both syscon and non-
syscon nodes. Am I correct?

> MODULE_DEVICE_TABLE(platform, reset_zx297520v3_ids);
> 
> With that,
> 
> 
> Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>

Thanks for the reviews and advice!

Cheers,
Stefan

Attachment: signature.asc
Description: This is a digitally signed message part.