Re: [PATCH] usb: typec: tcpm: Fix VDM type for Enter Mode commands

From: Greg KH

Date: Sat Jul 04 2026 - 07:09:06 EST


On Sat, Jul 04, 2026 at 05:41:53PM +0800, Andy Yan wrote:
> Hello,
>
> Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> 于2026年6月5日周五 20:58写道:
> >
> > On Thu, Jun 04, 2026 at 06:50:24PM +0800, Andy Yan wrote:
> > > VDO() second parameter is VDM type (bit 15): 1 for SVDM, 0 for UVDM.
> > > Using 'vdo ? 2 : 1' corrupts SVID low bit when vdo is non-NULL
> > > (2 << 15 = BIT(16)). Enter Mode is always SVDM, hardcode to 1.
> > >
> > > Fixes: 8face9aa57c8 ("usb: typec: Add parameter for the VDO to typec_altmode_enter()")
> > > Signed-off-by: Andy Yan <andyshrk@xxxxxxx>
> >
> > Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
>
>
> Gentle ping....
> Which maintainer can take this patch ?

Please relax, it was just reviewed yesterday. There is obviously no
rush here as it wasn't tagged for stable backports, so it will show up
in the 7.3 kernel release, right?

And as always, if you want patches to get accepted sooner, help out in
reviews to reduce our load.

thanks,

greg k-h