Re: [PATCH v6 0/6] New features for the AD5686 IIO driver
From: Jonathan Cameron
Date: Sun Jul 05 2026 - 19:30:53 EST
On Sun, 05 Jul 2026 12:38:55 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@xxxxxxxxxx> wrote:
> This is the second series of three on updating the AD5686 driver.
>
> Initially, a big patch series was sent:
> https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@xxxxxxxxxx
>
> Then, the first patch series added fixes and cleanups:
> https://lore.kernel.org/linux-iio/20260524-ad5686-fixes-v7-0-b6bf395d08bd@xxxxxxxxxx/
>
> This one is introducing new features:
> - Consume optional reset and correct power supplies;
> - LDAC GPIO handling (active-low, held low when unused);
> - SPI bus sync() implementation for batching multiple transfers;
> - Triggered buffer support, leveraging LDAC and sync() to flush
> all channel writes atomically;
> - Gain control support through the scale property.
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@xxxxxxxxxx>
I took another look through and also checked Sashiko output.
https://sashiko.dev/#/patchset/20260705-ad5686-new-features-v6-0-269594c7aae5%40analog.com
The i2c short access thing seems real so would be a nice additional trivial patch.
The other report is a false positive but I can see we have a naming
convention that is less than clear after the changes in patch 1.
Jonathan