Re: [PATCH v3] staging: media: atomisp: refactor pipe graph dump stage formatting

[Neal Patalay]

On Sun, Jul 5, 2026 at 7:22 AM Andy Shevchenko wrote:

> The blank line must divide the definition and code blocks.

Thanks, I'll fix this.

> Missing period at the end.

I'll fix this too.

> If for some reason len is > 0 and offset is 0, this will write beyond
> the boundaries.

I'll add a check to make sure the offset is greater than 0.

> Broken indentation. Note the statement fits a single line.

I'll put that all on one line.

> This will continue writing even if there are more than 3 lines.

The original code completely removes the third line from the output
by writing the third line into enable_info3, and then overwriting that
buffer with everything after the third line. I'll assume the author meant
to remove all flags after the third line.